Module talk:Wikidata art

	SpBot archives all sections tagged with {{Section resolved|1=~~~~}} after 1 day. For the archive overview, see Special:PrefixIndex/Module talk:Wikidata art/Archive. The latest archive is located at /Archive.

Collection, current location - Getty Center, J. Paul Getty Museum

should be vice versa, see example: File:Anthony van Dyck - Thomas Howard, 2nd Earl of Arundel - 86.PA.532 - J. Paul Getty Museum.jpg --Oursana (talk) 20:25, 26 February 2022 (UTC)

Private collection bugs

It looks like QuickStatements output puts private collection (Q768717) as mainsnak value instead of value of object of statement has role (P3831) qualifier. I guess this is because of <div style="display:none;">institution QS:P195,Q768717</div> in {{Private collection}}. Is there a process to convert these statements on Wikidata afterwards? --Marsupium (talk) 09:16, 27 March 2023 (UTC), 09:40, 27 March 2023 (UTC)

TODO: better integration with {{ProvenanceEvent}}

• / organizer (P664) somevalue qualifier -> |atunknown= (testcase: Girl with a Pearl Earring (Q185372))
• support multiple qualifiers of same property
• find equivalent of |result= on Wikidata and use here
• find equivalent(s) of |through= on Wikidata and use here
• find equivalent(s) of |by= on Wikidata and use here
• use simple creator (P170) qualifiers as equivalent of |as=???
• implement use of sourcing circumstances (P1480) (et al.?) for |status=

… in case me or someone else is looking for some useful improvements to work on. :-) --Marsupium (talk) 10:38, 18 December 2023 (UTC)

Another remark: deposit (Q5260774): making a cash deposit in a financial institution looks wrong as the item for "deposit". --Marsupium (talk) 11:09, 7 January 2024 (UTC)

Maybe use Module:Formatnum to format the value of price (P2284). --Marsupium (talk) 13:53, 26 October 2024 (UTC)

"edit at Wikidata icon" missing for function p.get_institution()

I've noticed this inconsistency once in a while, so now leaving a note here for the next time me or someone else feels like adding it. --Marsupium (talk) 10:01, 6 January 2024 (UTC)

Date and Author from "described by source (P1343)" not displayed

Hello,

the properties "Date" (or maybe "year") and "Author" are not displayed for references of type "described by source (P1343)". You can see the problem for instance at File:Tristychius arcuatus Cast of FOS169.jpg (uses a different module but with a call to the get_references function of the present module).

Tried to fix the issue myself as it appeared fairly trivial, but seeing that my edits failed to solve the problem, I reverted myself lest I break something, and I now report the issue here.

Cheers! Rama (talk) 16:03, 30 January 2024 (UTC)

Module:Wikidata_art#L-974 and following:

:		cite_arg.url     = p.P854 or ''	-- reference URL (P854)
:		cite_arg.volume  = p.P478 or ''	-- volume (P478)
:		cite_arg.pages   = p.P304 or ''	-- pages (P304)
:

where you tried to add author (P50) only evaluate qualifiers of described by source (P1343) statements on Wikidata. For the result that I think you're aiming for I think the author (P50) (mainsnak) statement of the value item of the described by source (P1343) statement would have to be evaluated. This would mean loading more data. Jarekt, what do you think? (As far as I remember you were a bit wary of this in the past.) Best, --Marsupium (talk) 12:17, 1 February 2024 (UTC)

Bug in evaluation of images for "other images"

It seems on the file of the value of image (P18) other images aren't used either, for example File:Karnak Tempel Vorhof Stele 01.jpg should show the image image of backside (P7417) File:Karnak Tempel Vorhof Stele 02.jpg, but doesn't. (Leaving this as a note here for the next time me or someone else feels like fixing it.) --Marsupium (talk) 19:02, 22 March 2024 (UTC)

Wrong order of work locations

In the following case they are not ordered cronologically: {{#invoke:Wikidata art|debug|wikidata=Q1504435|field=work_location|lang=en}} gives: Cologne (1609); Antwerp (1610 - 1623); London (1623 - 1665) . --Marsupium (talk) 14:34, 3 June 2024 (UTC)

Another example: {{#invoke:Wikidata art|debug|wikidata=Q2244591|field=work_location|lang=en}} gives: The Hague ( - 1878); Amsterdam (1880); London (1888); Utrecht (1878 - ); Nieuwer-Amstel (1885 - )  Marsupium (talk) 10:59, 17 October 2024 (UTC)

Apart from the missing feature of considering others than a start time (P580) qualifier, I think this edit has caused the bug because the timestamps include sub-day precision, so they are longer than 11 bytes. --Marsupium (talk) 06:41, 22 October 2024 (UTC)

Hello Jarekt! In tracking down the bug above, I found that this and this edit have caused unprocessed timestamps from Wikibase snaks' datavalue.value.time not to be valid input for Module:Calendar._date2jdn() any more. I see two possible ways to fix this:

1. We make the input of Module:Calendar._date2jdn() more liberal again like this.
2. We prepare the timestamp input in Module:Wikidata date._qualifierDate() before to fit the requested format.

Which one do you prefer? Thanks in advance, --Marsupium (talk) 10:35, 22 October 2024 (UTC)

Marsupium My edit was definitely wrong as I forgot about longer strings. I dropped "or #ISOdate>11" part. --Jarekt (talk) 13:42, 22 October 2024 (UTC)

Thank you for the very fast fix! I guess it fixes a bulk of orders. In order to order cases like

{{#invoke:Wikidata art|debug|wikidata=Q2244591|field=work_location|lang=en}} currently giving

"The Hague ( - 1878); Amsterdam (1880); London (1888); Utrecht (1878 - ); Nieuwer-Amstel (1885 - ) "

chronologically, the getPropertyQual() functions would need to use end time (P582) and point in time (P585) qualifiers as well. Do you have any objections regarding the code adjustments needed for that? Best, --Marsupium (talk) 14:57, 22 October 2024 (UTC)