User talk:Jack who built the house/Convenient Discussions

	SpBot archives all sections tagged with {{Section resolved|1=~~~~}} after 10 days and sections whose most recent comment is older than 360 days.

Mobile view

Hi @Jack who built the house, Is it possible to support mobile view in performance, if you do not have enough time to make it support mobile view, tell me which part is responsible for the view so that I can modify the performance.--Gerges (talk) 06:25, 27 August 2023 (UTC)

Hi. I haven't started with the mobile view so far because it's too fundamental a task to take on even for me. I don't even know where to start telling... And I was in the middle of a refactoring which would make the code architecture a bit easier to comprehend. Even though I strive to make my code maintainable and extendable by other people, I don't wanna disappoint you and give false hopes that this is feasible in reasonable time. Jack who built the house (talk) 11:29, 27 August 2023 (UTC)

Hi @Jack who built the house,

Is there anything new about making the tool support Mobile view.-- Gerges (talk) 16:24, 11 March 2024 (UTC)

Nothing new so far :( Jack who built the house (talk) 17:07, 11 March 2024 (UTC)

@JWBTH, What is the part of the code that prevents the tool from running on a mobile? -- Gerges (talk) 17:26, 11 March 2024 (UTC)

It's not that something is preventing the tool from running on mobile. You would need to write a large amount of code to provide support. Jack who built the house (talk) 17:35, 11 March 2024 (UTC)

Баг

Приветствую. Баг, возможно, связан с включенным DT. [1] (при редактировании, что до, что после сохранения часть [[ut: отсуствует в окошке). Jaguar K (talk) 15:40, 27 November 2023 (UTC)

Сложно ловить такие случаи. Скрипт думает, что ссылка с ut: — часть вашей подписи (потому что является ссылкой на вашу страницу обсуждения и стоит недалеко от конца сообщения). Jack who built the house (talk) 22:46, 21 April 2024 (UTC)

Отключить DT

Предложение отключить DT не учитывает статус "глобально отключен, локально включен" и потому в этом случае все ссылки в нем нерабочие. P.S. CD запускается по клику на function run() {importScript('MediaWiki:Gadget-convenientDiscussions.js')}, а не при загрузке страницы. Jaguar K (talk) 15:42, 27 November 2023 (UTC)

🤔 Jack who built the house (talk) 11:22, 10 February 2024 (UTC)

Hook for after replying

After adding a comment/topic or just pressing the refresh button with CD, the script reloads the page, removing most text appearance changes. Is there some sort of hook I should use for scripts that run again after CD refreshes the page after adding a new comment/topic? Aaron Liu (talk) 20:44, 27 November 2023 (UTC)

mw.hook('wikipage.content') should work, see https://doc.wikimedia.org/mediawiki-core/master/js/Hooks.html#~event:'wikipage.content'. Jack who built the house (talk) 12:23, 15 April 2024 (UTC)

Would that also work on the initial page load? I suspect that it would run on the page before CD processes it, resulting in a broken CD. Aaron Liu (talk) 16:35, 15 April 2024 (UTC)

resulting in a broken CD
Hm. CD fires the convenientDiscussions.pageReady hook when the processing is done, see https://tools-static.wmflabs.org/convenient-discussions/docs/global.html#event:pageReady. Jack who built the house (talk) 17:22, 15 April 2024 (UTC)

Well, for me the timestamps disable on reload despite me hooking it. Aaron Liu (talk) 18:01, 15 April 2024 (UTC)

This is the issue with that script, it doesn't provide the ability to run twice. By the way, do you really need it? CD converts timestamps in different formats as well per preferences. Jack who built the house (talk) 18:28, 15 April 2024 (UTC)

I like having the actual date show if the time is far away enough.
Anyways, I'll try looking at the script. Thanks! Aaron Liu (talk) 19:06, 15 April 2024 (UTC)

2 months and 17 days later, the solution was simple:

window.commentsInLocalTimeWasRun = false;

Aaron Liu (talk) 21:52, 1 July 2024 (UTC)

Keyboard shortcut/key for temporarily disabling bottom right overlay buttons

There's currently a gesture to hold the four buttons to make them disappear. Could a hotkey also be added for them?
Also, could the quote feature use normal positional parameter stuff instead of the nagging |1=? 😅 Aaron Liu (talk) 00:33, 2 December 2023 (UTC)

Also, could the quote feature use normal positional parameter stuff instead of the nagging |1=? 😅
↑ This quote would have broken if I didn't use it 😅 Jack who built the house (talk) 22:42, 21 April 2024 (UTC)

Как вытащить запрос из архива

@Jack who built the house and JWBTH: месяц назад я на ru:ВП:ЗКА подавал запрос, который сегодня ушёл в архив без итога. Возможно ли, так сказать, достать запрос из архива с помощью «Удобных обсуждений»? Guest Kashapov (talk) 06:08, 26 January 2024 (UTC)

@Guest Kashapov: Я реализовал эту функцию. Можете попробовать ей воспользоваться — выберите «Перенести» в меню заархивированной темы и перенесите, как обычно переносте темы. Jack who built the house (talk) 22:34, 21 April 2024 (UTC)

Опять съехала подсветка

Привет! Когда-то уже был такой баг, но вроде бы его исправляли. Подсветка новых сообщений съезжает существенно ниже. См., например, https://imgur.com/7kgIlMT Michgrig (talk) 14:59, 21 March 2024 (UTC)

Кря? Michgrig (talk) 19:04, 14 April 2024 (UTC)

Кря, да, мы обсуждали в последний раз на User talk:Jack who built the house/Convenient Discussions/Archives/2023#Кривая подсветка новых сообщений. Пока не могу ничего сказать. Вроде как число жалоб уменьшилось с прошлого раза, то есть баг относительно редок. Jack who built the house (talk) 11:12, 15 April 2024 (UTC)

problem

greetings We are using MediaWiki version 1.39, And recently in the changes you made there is code that is not compatible with this version of Media Wiki, I want to know if you can fix this problem. Thanks in advance. borrowed. שאול לרנר (talk) 11:00, 5 May 2024 (UTC)

More information: The issue is using mw.user.isNamed מיכי י-ם (talk) 11:03, 5 May 2024 (UTC)

Thanks for reporting, I should have known better before using mw.user.isNamed. I just fixed it; tell me if you still have any problems. By the way, who are "we" here? A non-WMF website? Jack who built the house (talk) 12:42, 5 May 2024 (UTC)

Back up and running. Thank you!

Directions to the site המכלול. מיכי י-ם (talk) 12:49, 5 May 2024 (UTC)

Thank you on behalf of all users of the website המכלולשאול לרנר (talk) 12:56, 5 May 2024 (UTC)

Another problem We don't have mw.util.clearSubtitle either.

Thanks in advance for the treatment! מיכי י-ם (talk) 09:01, 8 May 2024 (UTC)

Apologies for the harassment. We don't have globaluserinfo either. I allow myself to comment as we are using the long-term version of MediaWiki. Thanks again in advance מיכי י-ם (talk) 10:16, 8 May 2024 (UTC)

No apologies needed; you're doing my work for me, haha. Fixed these. Jack who built the house (talk) 11:26, 8 May 2024 (UTC)

Thank you for the reassuring response. The error still exists, the message is attached: Couldn't load the names of the muted users. TypeError: can't access property "globaluserinfo", e.query is undefined. מיכי י-ם (talk) 14:53, 8 May 2024 (UTC)

In addition, users report that the settings cannot be saved. Cause of error OO.ui.getTeleportTarget undefined. מיכי י-ם (talk) 14:55, 8 May 2024 (UTC)

I've improved compatibility with third-party wikis and older MediaWiki versions, fixing several other issues apart from the ones you mentioned. Please try now. Jack who built the house (talk) 21:03, 14 May 2024 (UTC)

Thank you! I didn't find any other issues (I don't use the script regularly). מיכי י-ם (talk) 09:28, 15 May 2024 (UTC)

Hebrew date

We would appreciate it if you added support for signature recognition that includes only a Hebrew date. Thanks in advance! מיכי י-ם (talk) 10:29, 7 May 2024 (UTC)

That would be tricky. Jack who built the house (talk) 21:02, 14 May 2024 (UTC)

Use ellipsis when edit summary is too long

Currently, CD only puts the comment contents into the edit summary if it can fit. Is it possible for it to replace the last characters with ... instead? Aaron Liu (talk) 01:23, 11 May 2024 (UTC)

The point of this feature is that if a comment is short (50 characters or less by default), the reader should be able to read it fully without opening the page. If it is longer, there is not much sense to show the first 50 characters of the comment – the reader would still have to open the page, and at the same time that text would create clutter for everyone else reading the edit history. Jack who built the house (talk) 01:59, 11 May 2024 (UTC)

Subscribing to Interest subscribes to Pakistan?

I've been trying to involve myself more in enwiki's AfD. I'm not sure if this is a problem with Echo, but when I (un)subscribe to en:w:Wikipedia:WikiProject Deletion sorting/Internet#Internet, I also simultaneously (un)subscribe en:w:Wikipedia:WikiProject Deletion sorting/Pakistan#Pakistan. Any ideas? Aaron Liu (talk) 15:13, 13 May 2024 (UTC)

This is how the subscription API works. You subscribe to a topic by the author and date of the oldest comment in it. In this case it's Saqib and 15:01, 15 April 2024 (UTC), see en:Wikipedia:WikiProject Deletion sorting/Internet#c-Saqib-20240415150100-Malik_Siraj_Akbar. Jack who built the house (talk) 15:24, 13 May 2024 (UTC)

Doesn't outdent

Despite my outdent level being set to 12, replying at w:User talk:Aaron Liu/sandbox did not cause outdents for me. Aaron Liu (talk) 16:39, 14 May 2024 (UTC)

Oh thank you, fixed. Jack who built the house (talk) 21:02, 14 May 2024 (UTC)

Removes section headers for some reason on Miraheze

After following the prompt to disable (most) of discussion tools, CD removes section headers' contents on every Miraheze talk page such as [2] for some reason Aaron Liu (talk) 14:26, 16 May 2024 (UTC)

Gosh, not only I have to constantly readjust CD to ever coming layout changes in DiscussionTools; I also have to support all the previous versions of it at once 😂 Fixed. Jack who built the house (talk) 21:43, 20 May 2024 (UTC)

Thanks! Sorry lol Aaron Liu (talk) 22:01, 20 May 2024 (UTC)

Discussion regarding potential feature request

I'm using CD often on the English Wikipedia, and have found excellent use of all the buttons that do code, bold, italics, etc...

Concerning the "Quote the Selected text" button, I find that I rarely use it and would benefit from this button being changed to using in-line quotation instead of quote block. Or would it be better to have two buttons, one for {{tqb}} and one for {{tq}}?

Looking forward to everyone's thoughts!

Cheers, Cocobb8 (talk) 13:39, 18 March 2024 (UTC)

Hi! I actually have thought myself that en:template:tq may be more reasonable than en:template:tqb, since

• you usually don't need to ping the user;
• long, multiline quotations (which look better in tqb) are rarely needed;
• more often than not you quote a comment directly above you, and the timestamp isn't helpful as well.

On the other hand, if we suppress the linking of the username and also provide a link to the target comment (which I suggested, but nobody commented), tqb would make more sense. Jack who built the house (talk) 14:57, 18 March 2024 (UTC)

That's why having both might be better? Note that I've seen much use of {{tq}} being used to quote from policies and guidelines too. Cocobb8 (talk) 15:11, 18 March 2024 (UTC)

 Done. Currently reverted to the use of en:template:tq. The ability to use the block template is still there (and used automatically in one special case when replying to a comment that has outdented replies, hence can't be replied directly). We need to think whether we need to use it in other cases and how. Jack who built the house (talk) 22:32, 21 April 2024 (UTC)

I will update the logic to the following:

1. The basic {{tq}} template is used when quoting the comment you reply to. No point to indicate the author/timestamp – it's already obvious.
2. {{tqb}} is used with author, timestamp, and comment ID parameters when quoting any other comment by selecting its text and pressing a toolbar button or q. (This won't work when pasting – the comment form won't know the source of the quote. But when pasting, the paste isn't formatted as a quote anyway.)

Jack who built the house (talk) 18:30, 19 May 2024 (UTC)

Sounds great to me! Aaron Liu (talk) 22:02, 20 May 2024 (UTC)

Welcomes

Hi. I started using CD on enwiki recently, and it seems broken on user talk pages with welcome templates. Other messages seem fine though. Could you look into this issue, thanks. '''[[User:CanonNi]]''' (talk • contribs) 01:06, 13 June 2024 (UTC)

Thanks, fixed.

By the way, you can quickly upload screenshots with CD by pasting or dragging the screenshot into the comment input or clicking the image tool and then "Upload". CD will automatically fill the image information for you. Jack who built the house (talk) 10:42, 13 June 2024 (UTC)

My signature at enwiki breaks

Hi JWBTH! Thanks for making this great script.
My signature at enwiki, which is ꧁Zanahary꧂, breaks, leaving a hanging ꧁ at the end of my comment as displayed with Convenient DIscussions. You can see an example here en:User_talk:Zanahary#A_beer_for_you!. Zanahary (talk) 03:54, 19 June 2024 (UTC)

Hi, detecting parts of signature is not an easy task. You can easily confuse a decoration element like ꧁ with an emoji which should not be removed. But I think I can get this case covered by checking if such an element is separated by a space or not. I've updated the script – ꧁ is no longer hanging. Jack who built the house (talk) 11:10, 19 June 2024 (UTC)

Thanks Jack! The signature is still breaking for me—do I need to reinstall the script? Zanahary (talk) 19:11, 19 June 2024 (UTC)

Oops, sorry – the release wasn't successful. Now everything should work. Jack who built the house (talk) 20:14, 19 June 2024 (UTC)

Awesome, thank you so much! You're a 🌠! Zanahary (talk) 20:28, 19 June 2024 (UTC)

New comments from yourself tattle us?

Hey @JWBTH! For like a month, this script has been telling me there's a new comment from myself whenever I comment for some reason despite how the comment is already loaded. Clicking on the grey link causes everything to refresh normally. Do you experience this? Is this a result of CommentsInLocalTime? Aaron Liu (talk) 11:30, 17 September 2024 (UTC)

Is this happening every time you comment? Jack who built the house (talk) 15:42, 17 September 2024 (UTC)

Yes, or at least nearly always. It appears after the next time I presume CD checks for new comments. Sometimes, but not always, I also get an error toast notification that prints "This skin does not support additions to the subtitle." to the console. Aaron Liu (talk) 16:33, 17 September 2024 (UTC)

Weird, that comment didn't produce it. I'm guessing it's on certain pages but I don't know the conditions. I reproduced it on my talk page. Aaron Liu (talk) 16:36, 17 September 2024 (UTC)

This skin does not support additions to the subtitle
This is not from CD (it's from mw.util.addSubtitle() method).

Which skin are you on? It could be connected to the skin. You could also try to disable CommentsInLocalTime.

I'm guessing it's on certain pages but I don't know the conditions.
Maybe it doesn't happen on Commons where you have a different set of preferences/scripts enabled? Jack who built the house (talk) 16:38, 17 September 2024 (UTC)

It happens on my own user talk page on commons. I'm using Vector 2022.

Hmm, now that I think about it, it may be my own watchlist notifier script. I'll debug it later. Aaron Liu (talk) 16:42, 17 September 2024 (UTC)

That did turn out to be the reason, by the way. Self-trout Aaron Liu (talk) 19:52, 27 September 2024 (UTC)

Invisible bullet points

Cryptic made a bulleted comment utilizing w:TM:i* to add a line after an embedded list. This made CD very confused: the comment is bulleted level (which I will now refer to as level 1), but it displayed it as root level (level 0) and level -1 at the same time, which displaying my level 2 reply as a level 1; the other level 1s are displayed correctly. Aaron Liu (talk) 19:55, 27 September 2024 (UTC)

Thanks, fixed. Btw, instead of trying to describe the behavior with words, it's easier and quicker to make a screenshot and upload it to Commons with CD. It's also easier and quicker for me to understand what's going on. Jack who built the house (talk) 04:37, 28 September 2024 (UTC)

Haha, my miserly tendencies tell me that I shouldn't waste storage space on disposable files. Aaron Liu (talk) 14:30, 28 September 2024 (UTC)

Screenshots take up an absolutely negligible amount of space. Jack who built the house (talk) 17:09, 28 September 2024 (UTC)

Didn't fix the level of your reply though. The issue here is that using en:template:invisible bullet results in an incorrect markup:

<ul>...<dl>...</dl>...</ul> (should be <ul>...<li>...<dl>...</dl></li>...</ul>)
I'll see what I can do, but generally I wouldn't recommend to use that template. Jack who built the house (talk) 19:44, 28 September 2024 (UTC)

GoToComment links

Sorry for bothering you again, but I often copy a comment's link and manually prefix the ID part with Special:GoToComment. Could the links view include such a link? Thanks! Aaron Liu (talk) 17:21, 3 October 2024 (UTC)

Can you clarify the use case? Is it the concern that the comment may be archived or moved? Do you copy a link or a wikilink?

There are already 5 types of links in the dialog. If I add 2 more links (1 link and 1 wikilink), there will be 7. Maybe I gotta replace some of them, need to think about it. Jack who built the house (talk) 00:06, 4 October 2024 (UTC)

I personally use the wikilink, while the permalink seems almost useless; plus, the developers refer to the GoToComment links as the permanent links instead of the Special:PermanentLinks. Aaron Liu (talk) 00:08, 4 October 2024 (UTC)

Well, the point of the permanent link is e.g. to link to abusive comments that may be further deleted on noticeboards. But a diff is equally sufficient in that case. So, yeah, replacing Special:PermanentLink with Special:GoToComment seems to make sense. Jack who built the house (talk) 00:12, 4 October 2024 (UTC)

Sections don't have an equally stable link though, so there will be two different types of permanent links. Or I need to come up with a different name for Special:GoToComment type links. Jack who built the house (talk) 00:18, 4 October 2024 (UTC)

 Done. Jack who built the house (talk) 00:41, 4 October 2024 (UTC)

Overwriting signatures?

Twice now: w:special:Diff/1260944230, w:special:Diff/1260952453, CD has overwritten the last characters of the comment I was replying to. Aaron Liu (talk) 17:41, 3 December 2024 (UTC)