Commons:User scripts/users namespace/reports/User:DieBuche/details.js
Jump to navigation
Jump to search
This is the report page for User:DieBuche/details.js. It is bot-maintained. All manual changes might be overwritten.
jshint
[edit]- ISSUE:
line 116 character 1
: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence:function titleFromLink (node)
- ISSUE:
line 158 character 32
: Use '===' to compare with '0'. - Evidence:if (!list || list.length == 0) return null;
- ISSUE:
line 161 character 38
: Use '===' to compare with '0'. - Evidence:var all = !keys || keys.length == 0;
- ISSUE:
line 176 character 17
: Use '===' to compare with '0'. - Evidence:if (found == 0) return null; else return result;
- ISSUE:
line 184 character 15
: ['Model'] is better written in dot notation. - Evidence:if (exif['Model']) {
- ISSUE:
line 185 character 17
: ['Make'] is better written in dot notation. - Evidence:if (exif['Make'] && exif['Model'].indexOf (exif['Make']) >= 0) exif['Make'] = null;
- ISSUE:
line 185 character 33
: ['Model'] is better written in dot notation. - Evidence:if (exif['Make'] && exif['Model'].indexOf (exif['Make']) >= 0) exif['Make'] = null;
- ISSUE:
line 185 character 56
: ['Make'] is better written in dot notation. - Evidence:if (exif['Make'] && exif['Model'].indexOf (exif['Make']) >= 0) exif['Make'] = null;
- ISSUE:
line 185 character 76
: ['Make'] is better written in dot notation. - Evidence:if (exif['Make'] && exif['Model'].indexOf (exif['Make']) >= 0) exif['Make'] = null;
- ISSUE:
line 188 character 17
: ['Make'] is better written in dot notation. - Evidence:if (exif['Make']) span.appendChild (document.createTextNode (exif['Make'] + ' '));
- ISSUE:
line 188 character 74
: ['Make'] is better written in dot notation. - Evidence:if (exif['Make']) span.appendChild (document.createTextNode (exif['Make'] + ' '));
- ISSUE:
line 190 character 25
: ['Model'] is better written in dot notation. - Evidence:exif['Model']
- ISSUE:
line 191 character 70
: ['Model'] is better written in dot notation. - Evidence:, 'http://en.wikipedia.org/wiki/' + encodeURI (exif['Model'])
- ISSUE:
line 199 character 22
: ['DateTime'] is better written in dot notation. - Evidence:var time = exif['DateTime'] || exif['DateTimeOriginal'] || null;
- ISSUE:
line 199 character 42
: ['DateTimeOriginal'] is better written in dot notation. - Evidence:var time = exif['DateTime'] || exif['DateTimeOriginal'] || null;
- ISSUE:
line 285 character 18
: 'i' is already defined. - Evidence:for (var i = 0; i < info.categories.length; i++) {
- ISSUE:
line 404 character 20
: 'i' is already defined. - Evidence:for (var i = 1; i < additional_links.length; i++) {
- ISSUE:
line 433 character 43
: Missing '()' invoking a constructor. - Evidence:GalleryDetailsTableViewer.prototype = new GalleryDetailsViewer;
- ISSUE:
line 522 character 39
: Use '===' to compare with '0'. - Evidence:if (!existing || existing.length == 0) return;
- ISSUE:
line 524 character 33
: The array literal notation [] is preferable. - Evidence:this.image_list = new Array ();
- ISSUE:
line 547 character 25
: Use '===' to compare with '0'. - Evidence:if (this.nof_images == 0) return;
- ISSUE:
line 590 character 97
: Use '===' to compare with '0'. - Evidence:if (request.status == 200 && request.responseText && request.responseText.indexOf ('{') == 0)
- ISSUE:
line 591 character 30
: eval can be harmful. - Evidence:this_obj.add_info (eval ('(' + request.responseText + ')'), from, length);
- ISSUE:
line 604 character 36
: Use '===' to compare with '0'. - Evidence:if (!title || title.length == 0) continue;
- ISSUE:
line 621 character 39
: The array literal notation [] is preferable. - Evidence:var categories = new Array();
- ISSUE:
line 643 character 52
: The array literal notation [] is preferable. - Evidence:this.image_list[i].users = new Array ();
- ISSUE:
line 676 character 21
: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence:function fix_double_encoding (match) {
- ISSUE:
line 687 character 54
: Use '!==' to compare with 'null'. - Evidence:while ((m = utf8.exec (str)) != null) {
- ISSUE:
line 734 character 33
: The array literal notation [] is preferable. - Evidence:this.viewer = new Array ();
- ISSUE:
line 744 character 20
: 'i' is already defined. - Evidence:for (var i = 0; i < this.viewer.length; i++)
- ISSUE:
line 793 character 23
: Use '===' to compare with '0'. - Evidence:if (tables.length == 0) {
- ISSUE:
line 798 character 23
: Use '===' to compare with '0'. - Evidence:if (tables.length == 0) return; // Nothing here: nothing to do.
- ISSUE:
line 806 character 52
: Script URL. - Evidence:,'javascript:GalleryDetailsLoader.load ();'
- ISSUE:
line 825 character 20
: 'i' is already defined. - Evidence:for (var i = 0; i < tables.length; i++) {
- ISSUE:
line 845 character 52
: 'i' used out of scope. - Evidence:, 'gallery_details_wrapper_' + i