Commons:User scripts/reports/MediaWiki:UploadFormTest.js
Jump to navigation
Jump to search
This is the report page for MediaWiki:UploadFormTest.js. It is bot-maintained. All manual changes might be overwritten.
jshint
[edit]- ISSUE:
line 29 character 55
: ['UploadForm_newlayout'] is better written in dot notation. - Evidence:(typeof (JSconfig) == 'undefined' || JSconfig.keys['UploadForm_newlayout']) ? null : true;
- ISSUE:
line 31 character 37
: Bad or unnecessary escaping. - Evidence:var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
- ISSUE:
line 31 character 39
: Bad or unnecessary escaping. - Evidence:var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
- ISSUE:
line 31 character 117
: Bad or unnecessary escaping. - Evidence:var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
- ISSUE:
line 31 character 119
: Bad or unnecessary escaping. - Evidence:var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
- ISSUE:
line 92 character 14
: Use '===' to compare with 'null'. - Evidence:if (rows == null) return minimum;
- ISSUE:
line 143 character 24
: Use '===' to compare with 'null'. - Evidence:if (wgUserLanguage == null || wgUserLanguage.length == 0) return;
- ISSUE:
line 143 character 57
: Use '===' to compare with '0'. - Evidence:if (wgUserLanguage == null || wgUserLanguage.length == 0) return;
- ISSUE:
line 157 character 17
: Use '===' to compare with '0'. - Evidence:if (i == 0)
- ISSUE:
line 241 character 64
: Bad or unnecessary escaping. - Evidence:'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
- ISSUE:
line 241 character 66
: Bad or unnecessary escaping. - Evidence:'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
- ISSUE:
line 241 character 80
: Bad or unnecessary escaping. - Evidence:'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
- ISSUE:
line 241 character 82
: Bad or unnecessary escaping. - Evidence:'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
- ISSUE:
line 283 character 12
: This character may get silently deleted by one or more browsers. - Evidence:ml: 'തര്ജ്ജമ',
- ISSUE:
line 339 character 21
: 'id' is already defined. - Evidence:for (var id in UFUI.defaultErrorMsgs) {
- ISSUE:
line 343 character 21
: 'id' is already defined. - Evidence:for (var id in UFUI.defaultHints) {
- ISSUE:
line 453 character 44
: Use '===' to compare with '0'. - Evidence:if (!close_imgs || close_imgs.length == 0)
- ISSUE:
line 476 character 14
: Use '!==' to compare with 'null'. - Evidence:if (fn != null) fn = fn.value;
- ISSUE:
line 477 character 14
: Use '!==' to compare with 'null'. - Evidence:if (fn != null) {
- ISSUE:
line 491 character 34
: Use '!==' to compare with 'null'. - Evidence:add_plea = (help_main != null);
- ISSUE:
line 498 character 42
: Use '!==' to compare with 'null'. - Evidence:add_plea = add_plea || (help_base != null);
- ISSUE:
line 529 character 19
: 'error' is already defined. - Evidence:var error = UFUI.getErrorMsg ('wpNoHelpTextError', true);
- ISSUE:
line 626 character 11
: Expected a 'break' statement before 'default'. - Evidence:}
- ISSUE:
line 676 character 23
: 'button_imgs' is already defined. - Evidence:var button_imgs = UFUI.getEntry ('wpUploadFormHelpOpenButton', 'uiElements', UFUI.internalLanguage);
- ISSUE:
line 678 character 23
: 'button_lk' is already defined. - Evidence:var button_lk = null;
- ISSUE:
line 681 character 44
: Use '===' to compare with '0'. - Evidence:if (!button_imgs || button_imgs.length == 0) {
- ISSUE:
line 736 character 31
: Use '!==' to compare with 'null'. - Evidence:if (current_dest_file != null) {
- ISSUE:
line 760 character 32
: 'current_dest_file' used out of scope. - Evidence:if (previous_file == current_dest_file) {
- ISSUE:
line 769 character 47
: Use '!==' to compare with 'null'. - Evidence:if (document.getElementById ('wpLicense') != null)
- ISSUE:
line 782 character 44
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.previous_hotcat_state != null && typeof (hotcat_set_state) == 'function') {
- ISSUE:
line 784 character 19
: Use '!==' to compare with 'null'. - Evidence:if (input != null) hotcat_cancel ();
- ISSUE:
line 792 character 53
: Bad or unnecessary escaping. - Evidence:if (desc && desc.value && desc.value.indexOf ('\{\{Information') >= 0) {
- ISSUE:
line 792 character 55
: Bad or unnecessary escaping. - Evidence:if (desc && desc.value && desc.value.indexOf ('\{\{Information') >= 0) {
- ISSUE:
line 808 character 23
: Use '!==' to compare with 'null'. - Evidence:if (target_name != null && target_name.value != null) // Strip whitespace
- ISSUE:
line 808 character 52
: Use '!==' to compare with 'null'. - Evidence:if (target_name != null && target_name.value != null) // Strip whitespace
- ISSUE:
line 812 character 26
: Use '!==' to compare with 'null'. - Evidence:&& target_name != null && target_name.value != null) {
- ISSUE:
line 812 character 55
: Use '!==' to compare with 'null'. - Evidence:&& target_name != null && target_name.value != null) {
- ISSUE:
line 816 character 21
: Use '!==' to compare with 'null'. - Evidence:if (input != null) hotcat_closeform ();
- ISSUE:
line 824 character 30
: Use '!==' to compare with 'null'. - Evidence:+ (hotcat_state != null ? '\t' + hotcat_state : '')
- ISSUE:
line 861 character 32
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.errorMsgs != null) delete UploadForm.errorMsgs;
- ISSUE:
line 862 character 40
: The array literal notation [] is preferable. - Evidence:UploadForm.errorMsgs = new Array ();
- ISSUE:
line 872 character 34
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.errorMsgs != null) delete UploadForm.errorMsgs;
- ISSUE:
line 873 character 42
: The array literal notation [] is preferable. - Evidence:UploadForm.errorMsgs = new Array ();
- ISSUE:
line 883 character 22
: Use '!==' to compare with 'null'. - Evidence:if (fields != null && fields.length == 4) {
- ISSUE:
line 884 character 30
: Use '===' to compare with 'null'. - Evidence:if ( fields[1] == null || fields[1].search (/\S/) < 0 // Author
- ISSUE:
line 885 character 30
: Use '===' to compare with 'null'. - Evidence:|| fields[2] == null || fields[2].search (/\S/) < 0) // Source
- ISSUE:
line 890 character 42
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.errorMsgs != null)
- ISSUE:
line 897 character 31
: Use '===' to compare with 'null'. - Evidence:&& (fields[3] == null || fields[3].search (/\S/) < 0)) // Description
- ISSUE:
line 908 character 21
: Use '===' to compare with 'null'. - Evidence:if (license == null || license.selectedIndex == 0) {
- ISSUE:
line 908 character 54
: Use '===' to compare with '0'. - Evidence:if (license == null || license.selectedIndex == 0) {
- ISSUE:
line 912 character 30
: Bad or unnecessary escaping. - Evidence:if (d.indexOf ('\{\{') < 0) {
- ISSUE:
line 912 character 32
: Bad or unnecessary escaping. - Evidence:if (d.indexOf ('\{\{') < 0) {
- ISSUE:
line 917 character 42
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.errorMsgs != null)
- ISSUE:
line 928 character 25
: Use '!==' to compare with 'null'. - Evidence:if (target_name != null) {
- ISSUE:
line 951 character 22
: Use '!==' to compare with 'null'. - Evidence:if (my_warning != null) my_warning.style.display = 'none';
- ISSUE:
line 968 character 37
: Use '===' to compare with 'null'. - Evidence:if (UploadFormFull.multi_inputs == null) {
- ISSUE:
line 995 character 42
: Use '===' to compare with 'null'. - Evidence:var new_row = content.insertRow (idx == null ? content.rows.length : idx);
- ISSUE:
line 1007 character 21
: Use '!==' to compare with 'null'. - Evidence:if (stored_form != null) {
- ISSUE:
line 1010 character 20
: Use '!==' to compare with 'null'. - Evidence:if (prev_val != null) textfield.value = prev_val;
- ISSUE:
line 1011 character 20
: Use '!==' to compare with 'null'. - Evidence:if (prev_idx != null) {
- ISSUE:
line 1047 character 21
: Use '!==' to compare with 'null'. - Evidence:if (stored_form != null) {
- ISSUE:
line 1057 character 62
: Use '===' to compare with '0'. - Evidence:&& stored_form[curr].id.indexOf ('wpLangSel') == 0) {
- ISSUE:
line 1060 character 88
: Use '===' to compare with '0'. - Evidence:if (curr < stored_form.length && stored_form[curr].id.indexOf ('wpDescText') == 0)
- ISSUE:
line 1069 character 20
: 'i' is already defined. - Evidence:for (var i = 0; i < UploadForm_description_languages.length; i++) {
- ISSUE:
line 1075 character 24
: Use '!==' to compare with 'null'. - Evidence:if (userLang != null && userLang != UFUI.defaultLanguage)
- ISSUE:
line 1080 character 24
: Use '!==' to compare with 'null'. - Evidence:if (userLang != null && userLang != UFUI.defaultLanguage)
- ISSUE:
line 1218 character 17
: Use '===' to compare with 'null'. - Evidence:if (label == null) label = UFUI.getLabel (id + 'UploadLbl');
- ISSUE:
line 1234 character 22
: Use '!==' to compare with 'null'. - Evidence:if (prev_value != null) field.value = prev_value;
- ISSUE:
line 1252 character 18
: Use '===' to compare with '0'. - Evidence:if (height == 0)
- ISSUE:
line 1276 character 17
: Use '===' to compare with 'null'. - Evidence:if (boxes == null || boxes.length == 0 || previous_form == null) return;
- ISSUE:
line 1276 character 41
: Use '===' to compare with '0'. - Evidence:if (boxes == null || boxes.length == 0 || previous_form == null) return;
- ISSUE:
line 1276 character 63
: Use '===' to compare with 'null'. - Evidence:if (boxes == null || boxes.length == 0 || previous_form == null) return;
- ISSUE:
line 1278 character 22
: Use '!==' to compare with 'null'. - Evidence:if (boxes[i] != null) {
- ISSUE:
line 1280 character 24
: Use '!==' to compare with 'null'. - Evidence:if (prev_val != null) boxes[i].checked = prev_val;
- ISSUE:
line 1304 character 29
: Use '!==' to compare with 'null'. - Evidence:if (current_dest_file != null) current_dest_file = current_dest_file.value;
- ISSUE:
line 1305 character 29
: Use '!==' to compare with 'null'. - Evidence:if (current_dest_file != null && current_dest_file.length > 0) {
- ISSUE:
line 1340 character 66
: Use '===' to compare with '0'. - Evidence:if (typeof (LanguageHandler) == 'undefined' || previous_type == 0) {
- ISSUE:
line 1369 character 17
: Use '!==' to compare with 'null'. - Evidence:if (license != null) {
- ISSUE:
line 1378 character 17
: Use '!==' to compare with 'null'. - Evidence:if (license != null) {
- ISSUE:
line 1380 character 16
: Use '!==' to compare with 'null'. - Evidence:if (prev != null) {
- ISSUE:
line 1392 character 15
: Use '!==' to compare with 'null'. - Evidence:if (src != null && (src.value == null || src.value.length == 0)) {
- ISSUE:
line 1392 character 37
: Use '===' to compare with 'null'. - Evidence:if (src != null && (src.value == null || src.value.length == 0)) {
- ISSUE:
line 1392 character 65
: Use '===' to compare with '0'. - Evidence:if (src != null && (src.value == null || src.value.length == 0)) {
- ISSUE:
line 1395 character 18
: Use '!==' to compare with 'null'. - Evidence:if (author != null && (author.value == null || author.value.length == 0)) {
- ISSUE:
line 1395 character 43
: Use '===' to compare with 'null'. - Evidence:if (author != null && (author.value == null || author.value.length == 0)) {
- ISSUE:
line 1395 character 74
: Use '===' to compare with '0'. - Evidence:if (author != null && (author.value == null || author.value.length == 0)) {
- ISSUE:
line 1401 character 18
: Use '!==' to compare with 'null'. - Evidence:if (date != null && (date.value == null || date.value.length == 0)) {
- ISSUE:
line 1401 character 41
: Use '===' to compare with 'null'. - Evidence:if (date != null && (date.value == null || date.value.length == 0)) {
- ISSUE:
line 1401 character 70
: Use '===' to compare with '0'. - Evidence:if (date != null && (date.value == null || date.value.length == 0)) {
- ISSUE:
line 1406 character 23
: Use '!==' to compare with 'null'. - Evidence:if (previous_form != null) {
- ISSUE:
line 1414 character 42
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.previous_hotcat_state != null && typeof (hotcat_set_state) == 'function') {
- ISSUE:
line 1416 character 17
: Use '!==' to compare with 'null'. - Evidence:if (input != null) hotcat_cancel ();
- ISSUE:
line 1425 character 37
: Use '===' to compare with 'null'. - Evidence:if (UploadFormFull.multi_inputs == null) {
- ISSUE:
line 1427 character 16
: Use '!==' to compare with 'null'. - Evidence:if (desc != null && !desc.disabled) desc_text = UploadForm.clean (desc.value);
- ISSUE:
line 1434 character 20
: Use '!==' to compare with 'null'. - Evidence:if (text != null && text.length > 0) {
- ISSUE:
line 1437 character 32
: Use '!==' to compare with 'null'. - Evidence:if (!basic && lang != null && lang.length > 0 && lang != 'unknown') {
- ISSUE:
line 1441 character 41
: Bad or unnecessary escaping. - Evidence:desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
- ISSUE:
line 1441 character 43
: Bad or unnecessary escaping. - Evidence:desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
- ISSUE:
line 1441 character 72
: Bad or unnecessary escaping. - Evidence:desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
- ISSUE:
line 1441 character 74
: Bad or unnecessary escaping. - Evidence:desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
- ISSUE:
line 1456 character 21
: Bad or unnecessary escaping. - Evidence:desc_text = '\{\{Information\n'
- ISSUE:
line 1456 character 23
: Bad or unnecessary escaping. - Evidence:desc_text = '\{\{Information\n'
- ISSUE:
line 1461 character 64
: Use '!==' to compare with 'null'. - Evidence:+ ((other && !other.disabled && other.value != null)
- ISSUE:
line 1464 character 76
: Use '!==' to compare with 'null'. - Evidence:+ ((othervers && !othervers.disabled && othervers.value != null)
- ISSUE:
line 1467 character 24
: Bad or unnecessary escaping. - Evidence:+ '\}\}\n';
- ISSUE:
line 1467 character 26
: Bad or unnecessary escaping. - Evidence:+ '\}\}\n';
- ISSUE:
line 1488 character 21
: Use '!==' to compare with 'null'. - Evidence:if (target_name != null && target_name.value != null) // Strip whitespace
- ISSUE:
line 1488 character 50
: Use '!==' to compare with 'null'. - Evidence:if (target_name != null && target_name.value != null) // Strip whitespace
- ISSUE:
line 1494 character 20
: Use '!==' to compare with 'null'. - Evidence:if (dummy_desc != null) dummy_desc.parentNode.removeChild (dummy_desc);
- ISSUE:
line 1497 character 24
: Use '!==' to compare with 'null'. - Evidence:&& target_name != null && target_name.value != null) {
- ISSUE:
line 1497 character 53
: Use '!==' to compare with 'null'. - Evidence:&& target_name != null && target_name.value != null) {
- ISSUE:
line 1501 character 19
: Use '!==' to compare with 'null'. - Evidence:if (input != null) hotcat_closeform ();
- ISSUE:
line 1512 character 28
: Use '!==' to compare with 'null'. - Evidence:+ (hotcat_state != null ? '\t' + hotcat_state : '')
- ISSUE:
line 1559 character 32
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.errorMsgs != null) delete UploadForm.errorMsgs;
- ISSUE:
line 1560 character 40
: The array literal notation [] is preferable. - Evidence:UploadForm.errorMsgs = new Array ();
- ISSUE:
line 1584 character 39
: Use '===' to compare with 'null'. - Evidence:if (UploadFormFull.multi_inputs == null) {
- ISSUE:
line 1586 character 18
: Use '!==' to compare with 'null'. - Evidence:if (desc != null) all_descs = desc.value;
- ISSUE:
line 1594 character 42
: Use '===' to compare with 'null'. - Evidence:var license_chosen = license_field == null || license_field.selectedIndex > 0;
- ISSUE:
line 1603 character 23
: Use '!==' to compare with 'null'. - Evidence:if (target_name != null) {
- ISSUE:
line 1620 character 43
: Use '===' to compare with 'null'. - Evidence:if (UploadFormFull.multi_inputs == null) {
- ISSUE:
line 1621 character 22
: 'desc' is already defined. - Evidence:var desc = document.getElementById ('wpDesc');
- ISSUE:
line 1622 character 22
: Use '!==' to compare with 'null'. - Evidence:if (desc != null) {
- ISSUE:
line 1640 character 22
: Use '!==' to compare with 'null'. - Evidence:if (my_warning != null) my_warning.style.display = 'none';
- ISSUE:
line 1647 character 37
: Use '===' to compare with 'null'. - Evidence:if (UploadFormFull.multi_inputs == null) return;
- ISSUE:
line 1681 character 27
: Use '!==' to compare with 'null'. - Evidence:if (hotcat_label_cell != null) {
- ISSUE:
line 1714 character 28
: Use '===' to compare with '0'. - Evidence:if (!id || id.length == 0) id = elems[i].name;
- ISSUE:
line 1717 character 36
: Confusing use of '!'. - Evidence:if (elems[i].disabled != !enabled) {
- ISSUE:
line 1739 character 22
: Use '!==' to compare with 'null'. - Evidence:if (my_warning != null) my_warning.style.display = 'none';
- ISSUE:
line 1748 character 24
: Use '===' to compare with 'null'. - Evidence:if ( stored_form == null || stored_form.length <= 1
- ISSUE:
line 1749 character 23
: Use '===' to compare with 'null'. - Evidence:|| element_id == null || element_id.length == 0)
- ISSUE:
line 1749 character 52
: Use '===' to compare with '0'. - Evidence:|| element_id == null || element_id.length == 0)
- ISSUE:
line 1752 character 26
: Use '!==' to compare with 'null'. - Evidence:if (stored_form[i] != null && element_id == stored_form[i].id)
- ISSUE:
line 1821 character 29
: Use '===' to compare with 'null'. - Evidence:if (preview_panel == null) return;
- ISSUE:
line 1827 character 42
: Use '===' to compare with '0'. - Evidence:if (!preview || preview.length == 0 || preview == ' ') {
- ISSUE:
line 1856 character 17
: Use '===' to compare with 'null'. - Evidence:if (request == null) return;
- ISSUE:
line 1860 character 22
: Use '===' to compare with 'null'. - Evidence:if (uploadButton == null) return;
- ISSUE:
line 1903 character 16
: Bad or unnecessary escaping. - Evidence:return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
- ISSUE:
line 1903 character 18
: Bad or unnecessary escaping. - Evidence:return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
- ISSUE:
line 1903 character 96
: Bad or unnecessary escaping. - Evidence:return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
- ISSUE:
line 1903 character 98
: Bad or unnecessary escaping. - Evidence:return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
- ISSUE:
line 1931 character 17
: Use '===' to compare with '0'. - Evidence:if (idx == 0) span = container;
- ISSUE:
line 1945 character 28
: 'default_text' is already defined. - Evidence:var default_text = UFUI.getLabel (default_id, true);
- ISSUE:
line 1961 character 30
: Use '===' to compare with '0'. - Evidence:if (!imgs || imgs.length == 0 || typeof (Buttons) == 'undefined') {
- ISSUE:
line 1963 character 22
: 'buttonText' is already defined. - Evidence:var buttonText = getButtonSpan (button, 0);
- ISSUE:
line 2072 character 38
: Use '!==' to compare with 'null'. - Evidence:(original_desc.defaultValue != null && original_desc.defaultValue.length > 0)
- ISSUE:
line 2073 character 31
: Missing semicolon. - Evidence:|| UploadForm.isReupload
- ISSUE:
line 2097 character 20
: Use '===' to compare with 'null'. - Evidence:if (my_warning == null) {
- ISSUE:
line 2136 character 31
: Use '!==' to compare with 'null'. - Evidence:if (my_warning.firstChild != null)
- ISSUE:
line 2146 character 32
: Use '!==' to compare with 'null'. - Evidence:if (UploadForm.oldOnSubmit != null) {
- ISSUE:
line 2148 character 21
: eval can be harmful. - Evidence:do_submit = eval (UploadForm.oldOnSubmit);
- ISSUE:
line 2148 character 21
: Too many errors. (75% scanned). - Evidence:undefined